Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate latest DatasourceMenu props into index-management MDS support #1030

Closed
wants to merge 1 commit into from
Closed

Integrate latest DatasourceMenu props into index-management MDS support #1030

wants to merge 1 commit into from

Conversation

CaptainDredge
Copy link
Contributor

@CaptainDredge CaptainDredge commented Apr 11, 2024 •
edited
Loading

Description

This PR updates index-management dashboard with the latest changes of data source picker component and removes dataSourceLabel from the URL

Issues Resolved

Resolves #1028

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@BionIT
Copy link

BionIT commented Apr 14, 2024

Thanks @CaptainDredge for the change! Noticed 3 pages don't have the data source id in the url

  1. notification - is it owned by a different plugin?
    Screenshot from 2024-04-14 16-34-35

  2. templates
    Screenshot from 2024-04-14 16-34-08

  3. data streams
    Screenshot from 2024-04-14 16-34-18

Will they be fixed in another PR?

Another thing noticed is the datasourceId in the url is set to empty string instead of the default data source thus in Neo use case, it would fail on initial load until user makes a different choice. To verify, use the recent main branch and switch the config in yaml data_source.hideLocalCluster: true

@CaptainDredge
Copy link
Contributor Author

notification - is it owned by a different plugin?

@BionIT Yes it is owned by notification plugin team owned by @praveensameneni

Template and datastreams are owned by us and recent changes in main should now have the datasourceId

To verify, use the recent main branch and switch the config in yaml data_source.hideLocalCluster: true

Recently, PR #1036 got merged in Main, can you check once if this behaviour still exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amsiglan amsiglan Awaiting requested review from amsiglan

@AWSHurneyt AWSHurneyt Awaiting requested review from AWSHurneyt

@bowenlan-amzn bowenlan-amzn Awaiting requested review from bowenlan-amzn bowenlan-amzn is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02

@praveensameneni praveensameneni Awaiting requested review from praveensameneni

@xluo-aws xluo-aws Awaiting requested review from xluo-aws

@gaobinlong gaobinlong Awaiting requested review from gaobinlong

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@lezzago lezzago Awaiting requested review from lezzago

@sbcd90 sbcd90 Awaiting requested review from sbcd90

@eirsep eirsep Awaiting requested review from eirsep

@r1walz r1walz Awaiting requested review from r1walz

@vikasvb90 vikasvb90 Awaiting requested review from vikasvb90 vikasvb90 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tracking Issue] Integrate latest changes of data source picker components to index-managment dashboard plugin
2 participants
@CaptainDredge @BionIT